Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #380 +/- ##
=======================================
Coverage 65.25% 65.25%
=======================================
Files 35 35
Lines 1632 1632
Branches 200 200
=======================================
Hits 1065 1065
Misses 523 523
Partials 44 44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the model list by removing deprecated models and adding new ones to the benchmark. The primary changes include removing older model versions that are no longer actively supported and adding two new models (DPA3_2_5M and MACE-MH-1) for benchmarking.
Key changes:
- Removed 9 deprecated models including DPA-2.4-7M, Orb-v2, SevenNet-l3i5, MACE-MP-0, and MACE-MPA-0
- Added two new models: DPA3_2_5M and MACE-MH-1 to the active model list
- Updated Orb-v3 to use the omat modality (orb_v3_conservative_inf_omat) and updated 7net-mf-ompa configuration for better performance
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lambench/models/models_config.yml | Removed 9 deprecated models by commenting them out and moving them to a "Deprecated Models" section; added two new models (MACE-MH-1 and DPA3_2_5M); updated Orb-v3 to show calculator task and removed deprecated flags; updated 7net-mf-ompa anchor definition; added supports_omol field to uma_m_1p1 |
| lambench/models/ase_models.py | Fixed the calc property signature by removing an invalid parameter that properties cannot accept |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR remove deprecated models like
DPA-2.4-7M,Orb-v2,SevenNet-l3i5,MACE-MP-0,MACE-MPA-0. Orb-v3 is updated toorb_v3_conservative_inf_omatand 7net-mf-ompa is updated to the omat modality for better performance.DPA3_2_5MandMACE-MH-1are included in the benchmark.