Skip to content

Conversation

@caic99
Copy link
Member

@caic99 caic99 commented Oct 12, 2024

Fix #5192
This pull request includes an update to the build configuration in the .github/workflows/coverage.yml file to enable additional features and libraries, in alignment to other tests.

@kirk0830
Copy link
Collaborator

@caic99 Hi, is there any difference in OMP threads number between intergrated test and lcov workflow?

@caic99
Copy link
Member Author

caic99 commented Oct 12, 2024

@caic99 Hi, is there any difference in OMP threads number between intergrated test and lcov workflow?

@kirk0830 Yes. As you can see, in coverage testing workflow the thread number is set to 1. Using more threads results in erroneous statistics on code coverage, and we've fixed it in an earlier commit.

@mohanchen mohanchen added the Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS label Oct 12, 2024
@mohanchen mohanchen merged commit 6b81902 into deepmodeling:develop Oct 12, 2024
14 checks passed
@caic99 caic99 deleted the fix-cov branch October 12, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: several tests failed in code converge test

3 participants