Remove DiagH Base class in pw #5225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haozhihan
approved these changes
Oct 14, 2024
mohanchen
approved these changes
Oct 14, 2024
16 tasks
Cstandardlib
added a commit
to Cstandardlib/abacus-develop
that referenced
this pull request
Oct 16, 2024
This reverts commit 0f0c838.
Fisherd99
pushed a commit
to Fisherd99/abacus-BSE
that referenced
this pull request
Mar 31, 2025
* Remove DiagoDavid Base class * Remove Diago_DavSubspace Base class * Remove DiagoCG Base class * Remove DiagoBPCG Base class * Remove DiagoBPCG Base class override * Update docs * Remove DiagH_mock in test_hsolver * Remove DiagH_mock in test_hsolver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue
Fix #5203
Base class
DiagHin LCAO code is retained.