Refactor: Use memory_op to set diag_const_nums #5246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
Fisherd99
pushed a commit
to Fisherd99/abacus-BSE
that referenced
this pull request
Mar 31, 2025
* Use memory_op to set consts * Fix segfault * Pyabacus test * Revert changes * Modify pointer usage * I will win * Malloc test * Initialize with nullptr * Remove useless code --------- Co-authored-by: Haozhi Han <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using memory_op to set diag_const_nums allows diag consts being directly allocated to some hardwares like dsp. Most hardwares don't need this because they will automatically copy the consts to their device, but some will need you to do this manually. This is a way to solve this issue. It is a foundation for transplanting abacus to dsp hardware( or some similar hardwares later ). This has not influence on devices like gpu and dcu.