Skip to content

Conversation

@dyzheng
Copy link
Collaborator

@dyzheng dyzheng commented Oct 31, 2024

Linked Issue

Fix #4895 #4890

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@mohanchen mohanchen added the Features Needed The features are indeed needed, and developers should have sophisticated knowledge label Oct 31, 2024
@mohanchen mohanchen requested a review from dzzz2001 October 31, 2024 08:57
@mohanchen mohanchen merged commit e276480 into deepmodeling:develop Nov 1, 2024
14 checks passed
Fisherd99 pushed a commit to Fisherd99/abacus-BSE that referenced this pull request Mar 31, 2025
…W code (deepmodeling#5377)

* Fix: noncollinear-spin force and stress with PW

* Fix: bug of pw force&stress calculation

* fix: soc error and cuda kernels

* Fix: CUDA and ROCM

* [pre-commit.ci lite] apply automatic fixes

* Fix: nspin=4 error on DCU/GPU

* Refactor: format and less parameters for nonlocal fs kernels

* Test: add force and stress test for noncollinear-spin and soc

---------

Co-authored-by: dyzheng <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Features Needed The features are indeed needed, and developers should have sophisticated knowledge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NSPIN=4 with PW and GPU/DCU would cause error results.

3 participants