Skip to content

Conversation

@WHUweiqingzhou
Copy link
Collaborator

@WHUweiqingzhou WHUweiqingzhou commented Nov 13, 2024

Fix #5192

In coverage test, we use

OMP_NUM_THREADS=1 mpirun -np 8 abacus

while in CI tests, we use

OMP_NUM_THREADS=2 mpirun -np 4 abacus

Under these two parallelism, ABACUS gives the result difference above the threshold in 6 cases:

Warning: NG]    1 test cases out of 1547 failed.
1: 102_PW_PINT_UKS
1: 
1: [ERROR     ] 5 test cases out of 1547 produced fatal error.
1: 260_NO_DJ_PK_PU_FM
1: 260_NO_DJ_PK_PU_SO
1: 260_NO_DJ_PK_PU_S1
1: 260_NO_DJ_PK_PU_AFM_URAMPING
1: 304_NO_GO_AF_atommag

In fact, CI testing ensures the correctness of the code, while coverage detection may not check for correctness.

@codecov
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.18%. Comparing base (146a509) to head (f9b0101).
Report is 69 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5469      +/-   ##
===========================================
+ Coverage    74.08%   74.18%   +0.09%     
===========================================
  Files         1118     1123       +5     
  Lines       105254   105727     +473     
  Branches     14578    14627      +49     
===========================================
+ Hits         77978    78432     +454     
+ Misses       21355    21249     -106     
- Partials      5921     6046     +125     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WHUweiqingzhou WHUweiqingzhou changed the title Converge Fix: let the coverage test pass without checking for its correctness Nov 13, 2024
@mohanchen mohanchen added the Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS label Nov 13, 2024
@mohanchen mohanchen merged commit a2fdb95 into develop Nov 13, 2024
28 checks passed
@WHUweiqingzhou WHUweiqingzhou deleted the converge branch November 13, 2024 06:03
Fisherd99 pushed a commit to Fisherd99/abacus-BSE that referenced this pull request Mar 31, 2025
…eepmodeling#5469)

* correct the converge test

* increase the time limit of converge test

* Revert "increase the time limit of converge test"

This reverts commit 60307ff.

* Revert "correct the converge test"

This reverts commit a4b9ede.

* make coverage pass without checking the correctness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: several tests failed in code converge test

3 participants