Skip to content

Fix GPU memory recorder's memory leak #5491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Fix GPU memory recorder's memory leak #5491

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f42b4f4
Fix memory leak
Critsium-xy Nov 14, 2024
4adca2b
Remove useless things
Critsium-xy Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions source/module_base/memory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ int Memory::short_memory = sizeof(short); // 2.0 Byte

int Memory::n_memory = 1000;
int Memory::n_now = 0;
bool Memory::init_flag = false;
bool Memory::init_flag = false;

#if defined(__CUDA) || defined(__ROCM)

Expand Down Expand Up @@ -365,18 +365,15 @@ void Memory::finish(std::ofstream &ofs)
delete[] name_gpu;
delete[] class_name_gpu;
delete[] consume_gpu;
init_flag_gpu = false;
}
#endif
return;
}

void Memory::print_all(std::ofstream &ofs)
{
if(!init_flag
#if defined(__CUDA) || defined(__ROCM)
&& !init_flag_gpu
#endif
)
if(!init_flag)
{
return;
}
Expand Down Expand Up @@ -437,6 +434,11 @@ void Memory::print_all(std::ofstream &ofs)
}

#if defined(__CUDA) || defined(__ROCM)
if(!init_flag_gpu)
{
return;
}

ofs <<"\n NAME-------------------------|GPU MEMORY(MB)----" << std::endl;
ofs <<std::setw(30)<< "total" << std::setw(15) <<std::setprecision(4)<< Memory::total_gpu << std::endl;

Expand Down
Loading