Skip to content

Conversation

@dyzheng
Copy link
Collaborator

@dyzheng dyzheng commented Nov 19, 2024

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #5522

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@dyzheng dyzheng requested a review from kirk0830 November 19, 2024 03:56
@mohanchen mohanchen added the Refactor Refactor ABACUS codes label Nov 19, 2024
@mohanchen mohanchen merged commit 8040017 into deepmodeling:develop Nov 19, 2024
14 checks passed
@mohanchen mohanchen added the Bugs Bugs that only solvable with sufficient knowledge of DFT label Nov 19, 2024
Fisherd99 pushed a commit to Fisherd99/abacus-BSE that referenced this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugs Bugs that only solvable with sufficient knowledge of DFT Refactor Refactor ABACUS codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Question: integrated test case 140_PW_15_SO fails in PR#5517 and #5519

3 participants