Fix: support lmax of orbital 8,9 #5528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohanchen
approved these changes
Nov 19, 2024
Collaborator
|
there is a PR by me needed to merge to @QuantumMisaka's lmax9 branch, please wait till my PR is merged |
Enhance: throw with information when there are unexpected spetrum symbol
Collaborator
|
this PR is mainly completed by @QuantumMisaka, I add minor throw information suggested by @hebrewsnabla. |
kirk0830
approved these changes
Nov 20, 2024
Fisherd99
pushed a commit
to Fisherd99/abacus-BSE
that referenced
this pull request
Mar 31, 2025
* Fix: support lmax of orbital 8,9 * Enhance: throw with information when there are unexpected spetrum symbol --------- Co-authored-by: kirk0830 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reminder
Linked Issue
Supplement for #5507
Unit Tests and/or Case Tests for my changes
What's changed?
Any changes of core modules? (ignore if not applicable)