Skip to content

Refactor:Remove the dependency of the Psi in the FFT module #5564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 26, 2024
Merged

Refactor:Remove the dependency of the Psi in the FFT module #5564

merged 14 commits into from
Nov 26, 2024

Conversation

@A-006
Copy link
Collaborator

@A-006 A-006 commented Nov 21, 2024

Unit Tests and/or Case Tests for my changes

  • In the module_pw/test,there is a Makefile which test the module_fft.Modify the file to test the memory safety and correctness of the fft.

What's changed?

  • Remove the dependency of the psi.h,move the check func of the cufft into the module_fft.

@A-006 A-006 requested review from Qianruipku and caic99 November 21, 2024 12:36
@A-006 A-006 changed the title Refactor:Remove the dependency of the psi in fft. Refactor:Remove the dependency of the psi in fft Nov 21, 2024
@caic99 caic99 removed their request for review November 21, 2024 12:53
mohanchen
mohanchen reviewed Nov 22, 2024
View reviewed changes
@mohanchen mohanchen added the Refactor Refactor ABACUS codes label Nov 22, 2024
@mohanchen mohanchen changed the title Refactor:Remove the dependency of the psi in fft Refactor:Remove the dependency of the Psi in the FFT module Nov 23, 2024
@A-006 A-006 marked this pull request as draft November 23, 2024 08:55
@A-006 A-006 marked this pull request as ready for review November 23, 2024 10:12
@mohanchen mohanchen merged commit 664f996 into deepmodeling:develop Nov 26, 2024
14 checks passed
Fisherd99 pushed a commit to Fisherd99/abacus-BSE that referenced this pull request Mar 31, 2025
@A-006 @pre-commit-ci-lite @Fisherd99
Refactor:Remove the dependency of the Psi in the FFT module (deepmode…
8f53122 
…ling#5564)

* delete fft.cpp

* update the psi.h

* update the header file

* add clear func

* change the fft makefile

* delete fft.h

* update the Makefile.Obj

* [pre-commit.ci lite] apply automatic fixes

* revert check_func

* update the header file

* change fft_cpu.h

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mohanchen mohanchen mohanchen approved these changes

@Qianruipku Qianruipku Qianruipku approved these changes

Assignees

No one assigned

Labels

Refactor Refactor ABACUS codes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@A-006 @mohanchen @Qianruipku