Skip to content

Fix: symmetry prec mismatch between real and reciprocal space lattice #5623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 27, 2024
Merged

Fix: symmetry prec mismatch between real and reciprocal space lattice #5623

merged 2 commits into from
Nov 27, 2024

Conversation

@dyzheng
Copy link
Collaborator

@dyzheng dyzheng commented Nov 27, 2024 •
edited by WHUweiqingzhou
Loading

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #4171
Fix #4739

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@mohanchen mohanchen added Symmetry This issue is related to symmetry Refactor Refactor ABACUS codes labels Nov 27, 2024
@dyzheng
Copy link
Collaborator Author

dyzheng commented Nov 27, 2024

This PR has also solved error of this report https://deepmodeling-activity.github.io/abacus-test.github.io/index.html?pname=alloy/symmetry

@WHUweiqingzhou WHUweiqingzhou merged commit f7b62a7 into deepmodeling:develop Nov 27, 2024
14 checks passed
@WHUweiqingzhou WHUweiqingzhou mentioned this pull request Nov 27, 2024
Closed
16 tasks
Fisherd99 pushed a commit to Fisherd99/abacus-BSE that referenced this pull request Mar 31, 2025
@dyzheng @Fisherd99
Fix: symmetry prec mismatch between real and reciprocal space lattice (…
3bdcc2b 
…deepmodeling#5623)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mohanchen mohanchen mohanchen approved these changes

Assignees

No one assigned

Labels

Refactor Refactor ABACUS codes Symmetry This issue is related to symmetry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Large force difference when set different symemtry_prec Bugs in cell-relax with symmetry=1

3 participants

@dyzheng @mohanchen @WHUweiqingzhou