Skip to content

Refactor: wavefunc.cpp #5646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 29, 2024
Merged

Refactor: wavefunc.cpp #5646

merged 3 commits into from
Nov 29, 2024

Conversation

@haozhihan
Copy link

@haozhihan haozhihan commented Nov 29, 2024

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #...

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@haozhihan haozhihan changed the title just test Refactor: wavefunc.cpp Nov 29, 2024
@haozhihan haozhihan marked this pull request as ready for review November 29, 2024 08:48
@haozhihan haozhihan requested a review from mohanchen November 29, 2024 08:52
@mohanchen mohanchen merged commit 8b4d10f into deepmodeling:develop Nov 29, 2024
14 checks passed
@haozhihan haozhihan deleted the psi-init branch November 30, 2024 03:29
Fisherd99 pushed a commit to Fisherd99/abacus-BSE that referenced this pull request Mar 31, 2025
@haozhihan @Fisherd99
Refactor: wavefunc.cpp (deepmodeling#5646)
79300ad 
* refactor diago_PAO_in_pw_k2 func

* refator wavefunc

* refactor wavefunc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mohanchen mohanchen mohanchen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@haozhihan @mohanchen