Skip to content

Conversation

@A-006
Copy link
Collaborator

@A-006 A-006 commented Dec 4, 2024

Unit Tests and/or Case Tests for my changes

  • Remove GlobalC::ucell in module_io test.

What's changed?

  • Remover GlobalC::ucell in module_io
  • In source/module_io/to_wannier90_h,the get_trial_orbitals_lm_k function requires tpiba, and the integral function requires omega. Since these two functions are called in many places, the set_omega_tpiba function is set to pass parameters.

@YuLiu98 YuLiu98 changed the title Refactor:Remover GlobalC::ucell in module_io Refactor:Remove GlobalC::ucell in module_io Dec 4, 2024
@YuLiu98 YuLiu98 merged commit e555490 into deepmodeling:develop Dec 4, 2024
14 checks passed
@YuLiu98 YuLiu98 added the The Absolute Zero Reduce the "entropy" of the code to 0 label Dec 4, 2024
Fisherd99 pushed a commit to Fisherd99/abacus-BSE that referenced this pull request Mar 31, 2025
* change ucell in module_io

* change ucell in module_io/cal_r_overlap.cpp

* change ucell in module_io/cal_test.cpp

* change ucell in module_io/get_wf_lcao.cpp

* change ucell in module_io/numerical_desciptor.cpp

* change ucell in module_io/read_wfc_to_rho.cpp

* change ucell in module_io/td_current_io.cpp

* change ucell in module_io/to_wannier90_lcao_in_pw.cpp

* change ucell in module_io/to_wannier90_pw.cpp

* change ucell in module_io/to_wannier90_lcao.cpp

* change ucell in module_io/to_wannier90.cpp

* change ucell in module_io/write_vxc_lip.hpp.cpp

* change ucell in module_io/unk_overlap_lcao.cpp

* change ucell in module_io/write_dipole.cpp

* change ucell in module_io/write_dmr.cpp

* change ucell in module_io/write_dos_lcao.cpp

* change ucell in module_io/write_elecstat_pot.cpp

* change ucell in module_io/write_wfc_r.cpp

* change ucell in bessel_basis_test.cpp

* change ucell in read_wfc_to_rho_test.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

The Absolute Zero Reduce the "entropy" of the code to 0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants