Skip to content

Refactor: rewrite module neighbour to parition atom into boxes #5681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

Refactor: rewrite module neighbour to parition atom into boxes #5681

wants to merge 10 commits into from

Conversation

@goodchong
Copy link
Collaborator

@goodchong goodchong commented Dec 4, 2024 •
edited
Loading

Unit Tests and/or Case Tests for my changes

  • fresh unit test according to refactor

What's changed?

  • rewrite module neighbour to parition atom into boxes
  • format file source/module_cell/module_neighbor/sltk_atom_arrange.cpp, remove some useless parameter in atom input
  • merge atom input and grid

Any changes of core modules? (ignore if not applicable)

  • module_neighbor

@goodchong goodchong changed the title Refactor: format file source/module_cell/module_neighbor/sltk_atom_arrange.cpp Refactor: rewrite module neighbour to parition atom into boxes Dec 4, 2024
@goodchong goodchong closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@goodchong