Skip to content

Conversation

@A-006
Copy link
Collaborator

@A-006 A-006 commented Dec 9, 2024

What's changed?

  • Remove Ucell in EXX and module_ri
  • Remove GlobalC::ucell in module_lcaodft with EXX
  • The contributeHR in module_lcaodft/operator_lcao/op_exx_lcao.h need to override the vritual function.Thus i should change all the contributeHR with parameter ucell,so i add the const reference of ucell in this class.

@A-006 A-006 requested a review from maki49 December 9, 2024 08:00
@mohanchen mohanchen added the The Absolute Zero Reduce the "entropy" of the code to 0 label Dec 10, 2024
@mohanchen mohanchen merged commit 3afb499 into deepmodeling:develop Dec 10, 2024
14 checks passed
Fisherd99 pushed a commit to Fisherd99/abacus-BSE that referenced this pull request Mar 31, 2025
* change ucell in module_exx/exx_lri_interface.hpp

* change ucell in exx_lri/init

* change ucell in exx_abfs-construct.cpp

* change ucell in module_ri/exx_abfs-jle.cpp

* change ucell in module_ri/exx_lip.hpp

* change ucell in module_ri/exx_lri.hpp

* change ucell in module_ri/exx_lir.hpp/cal_exx_elec

* change ucell in module_ri/exx_lri.hpp

* change ucell in module_ri/exx_opt-print.hpp

* change ucell in module_ri/exx_opt.cpp

* change ucell in module_ri/rpa_lri.cpp

* change ucell in module_ri/rpa_lri_tool.cpp

* change ucell in module_ri/ri_2d_comm.cpp

* change ucell in module_ri/ri_2d_comm.cpp

* change ucell in module_ri/rpa_lri.cpp

* change ucell in module_ri/lri_cv_tools.cpp

* change ucell in module_ri/matirx_orb11.cpp

* change ucell in module_ri/matirx_orb21.cpp

* change ucell in module_ri/matirx_orb2.cpp

* change lat0 in Matrix.cpp

* change ucell in Matrix.cpp

* change ucell in module_ri/matirx_orb22,matirx_orb11.cpp

* [pre-commit.ci lite] apply automatic fixes

* update reference of lat0 in ri

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

The Absolute Zero Reduce the "entropy" of the code to 0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants