Refactor: refactor the constructors of Psi class #5761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt nk_in, int nband_in)
mohanchen
reviewed
Jan 4, 2025
mohanchen
approved these changes
Jan 5, 2025
Fisherd99
pushed a commit
to Fisherd99/abacus-BSE
that referenced
this pull request
Mar 31, 2025
* remove Psi(const Psi& psi_in, const int nk_in, int nband_in); * fix bug * fix bug * [pre-commit.ci lite] apply automatic fixes * remove device value in psi * update Psi(const Psi& psi_in, const int nk_in, int nband_in) * update get_ngk usage * fix bug about ngk * [pre-commit.ci lite] apply automatic fixes * fix bug * format operator * [pre-commit.ci lite] apply automatic fixes * fix bug * fix bug * fix bug * fix bug * add get_cur_effective_basis func * fix bug * update get_cur_effective_basis * check bugs * update Constructor 8-1 * fix bug * fix bug * fix bug * fix bug maybe * fix bug * check correct * check 1 * fix unit test * fix unit bug * update get_ngk func * remove get-ngk in velocity-pw * fix bug * [pre-commit.ci lite] apply automatic fixes * fix 186_PW_SKG_ALL bug * format source/module_io/unk_overlap_pw.cpp * update Constructor in psi * [pre-commit.ci lite] apply automatic fixes * debug unit test * fix ri test bug * [pre-commit.ci lite] apply automatic fixes * fix psi-ut bug * remove Psi<T, Device>::Psi(T* psi_pointer, const Psi& psi_in, const int nk_in, int nband_in) * remove useless code * update Psi(const Psi& psi_in, const int nk_in, const int nband_in); * remove Psi(const Psi& psi_in, const int nk_in, const int nband_in); * refactor psi code * fix sdft bug * change to get_current_ngk --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5746