Refactor: Remove global dependence in force/stress calculation in DeePKS. #5824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohanchen
added
Refactor
mohanchen
approved these changes
Jan 7, 2025
Fisherd99
pushed a commit
to Fisherd99/abacus-BSE
that referenced
this pull request
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit Tests and/or Case Tests for my changes
gvepslin unit test and corresponding reference files.gvx, since it was incompletely printed in the previous version.What's changed?
gdmxandgvxto deepks_fpre.cpp (since they are used for DeePKS force calculations) and remove their global dependence. Change the print forgvxinto correct size.gdmepslandgvepslto deepks_spre.cpp (since they are used for DeePKS stress calculations) and remove their global dependence. Add function for printinggvepsl.