Skip to content

Reactor:Add unittest for module_fft #5841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Reactor:Add unittest for module_fft #5841

wants to merge 7 commits into from

Conversation

@A-006
Copy link
Collaborator

@A-006 A-006 commented Jan 9, 2025

Unit Tests and/or Case Tests for my changes

  • Enable ENABLE_FLOAT_FFTW=ON to test the fftwf functionality.
  • Added two unit tests: one utilizes fftwf, while the other does not, ensuring comprehensive testing of single precision in ABACUS integration tests.

What's changed?

  • Fixed the logic for handling precision and device settings in fft_bundle. Specifically:
  • When the device is set to "gpu" but neither CUDA nor ROCm is available, the precision is now correctly set to "cpu".
  • Added a warning quit when attempting to use single precision on the CPU without compiling fftwf.

@A-006 A-006 marked this pull request as draft January 9, 2025 13:59
@A-006 A-006 closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@A-006