forked from abacusmodeling/abacus-develop
-
Notifications
You must be signed in to change notification settings - Fork 145
First stage of add DSP FFT #5878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohanchen
reviewed
Jan 26, 2025
mohanchen
reviewed
Feb 24, 2025
mohanchen
reviewed
Feb 25, 2025
mohanchen
approved these changes
Feb 26, 2025
Fisherd99
pushed a commit
to Fisherd99/abacus-BSE
that referenced
this pull request
Mar 31, 2025
* set fft_dsp * add information in map * update Global_rank * update control flow * [pre-commit.ci lite] apply automatic fixes * add the fft_dsp in the fft_bundle * change teh cmake file * modify back scalapck * set the dsp ig2ixyz_k_cpu * modify the pw_basis * add the namespace * remove mutable * fix fft_dsp * add the convolution and allocate or destroy the b_id --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Features Needed
The features are indeed needed, and developers should have sophisticated knowledge
GPU & DCU & HPC
GPU and DCU and HPC related any issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACHIEVEMENT
When compiling ABACUS with the DSP=ON option, the software automatically configures the FFT device to utilize DSP. This configuration demonstrates significant performance improvements, achieving over 30 times the speed compared to the FT cluster. Additionally, it exhibits strong scalability.I would like to acknowledge the contributions of the author of the mt_3d_fft library and extend my gratitude to @Qianruipku for their valuable input. Special thanks are also due to @mohanchen for significant support .Due to the check of the compuer ,i temporarially add the first stage of the DSP FFT.
Attention
1.FUNCTION:This is not the final step in porting DSP computations. After specifying MT_FFT_LIBRARY, MT_FFT_INCLUDE, and MT_HRHREAD, the DSP can be utilized to compute FFT. Currently, simultaneous use of DSP FFT and BLAS is not supported. Features for this will be promptly added.

2.PERFOMANCE: At present, the DSP FFT does not achieve its fastest performance, as some memory copies have not yet been optimized. This aspect will also be optimized in the future.Some functions in real_to_recip do not utilize memcpy or zapy_. These functions could be optimized or potentially moved to the DSP for improved performance.
What's changed?
Attention