-
Notifications
You must be signed in to change notification settings - Fork 145
changing test 218 #6088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changing test 218 #6088
Conversation
|
Do we have tests that use mixed kinetic energy density? |
|
Sorry, I don't understand why we need to remove a test when we find a bug? |
Sorry for the confusion. The test that revealed this bug is likely to fail in the CI/CD. Because we have submitted an issue relating to this bug, we will try to fix this bug as we resolve the issue, and add the test back. And to respond to the previous question on whether we had a test on mixed kinetic energy density, the test was not there until 4 days ago. @dyzheng was unable to make this test pass when he tried to merge from the develop branch. So now the plan is to remove the test, so the develop branch can be merged to other people's branches, meanwhile we will try to fix this bug. |
|
Make sense, thanks for the explanation. |
|
I found there is a conflict, should we fix it before merging the PR? |
Definitely. I'll update you when this conflict is resolved tmr. (Sorry for the delay.) |
OK, thanks. |
The code should be in good shape and ready to merge now. Please feel free to approve and merge it anytime. |
Reminder
Due to an unexpected behavior of running parallelly with 2 cores as reported in outlying behavior when running with 2 cores for mixing kinetic energy density #6086, the integrate test 218 is deleted such that it does not use mixed kinetic energy density (calculations using which yield a different result with 2 cores compared with those with a different number of cores) during the test calculation.
Linked Issue
Concerned with #6086 but not yet resolved.
Unit Tests and/or Case Tests for my changes
N.A.
What's changed?
Integrate test 218 is removed.
Any changes of core modules? (ignore if not applicable)
N.A.