-
Notifications
You must be signed in to change notification settings - Fork 146
Feature&Fix: Correct implementation of length-gauge electric fields and ionic forces in RT-TDDFT (Useful information for fixed-bug version of rt-TDDFT) #6441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The validation looks good. The result is proved to be internally consistent in the length gauge. But I still want to confirm the details about the direction of the electric field. Generally, we work with two types of coordinates: fractional(direct) coordinates and Cartesian coordinates, the latter always being orthogonal. The conversion between the two coordinate systems is given by: |
@ESROAMER Yes, this PR changed the direction of electric field in length gauge to Cartesian coordinates, which should be consistent with velocity gauge and hybrid gauge. Line 195 basically means projecting to the Cartesian x-axis: |
I see, thanks for your clarification. I'll do some tests as well. |
Description
This PR addresses a critical implementation error in length-gauge RT-TDDFT.
1. Critical Bug Fix
a=b=c
). Calculations were accidentally correct only for cubic systems due to hidden simplifications in the coordinate transformations. Now it can properly handle arbitrary lattice vectors.2. Validation
fcs
is the total force, andfefield_tddft
is the ionic electric field force, the unit is eV/Å):3. Completely rewritten RT-TDDFT documentation