[Refactor] Move module_fft to source_base #6508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This PR also renames its namespace, this caused quite a lot of code and CMake file changes. |
Critsium-xy
force-pushed
the
move_fft
branch
from
b67545c to
186d144
Compare
mohanchen
approved these changes
Sep 17, 2025
mohanchen
added
Refactor
kluonj
pushed a commit
to kluonj/abacus-develop
that referenced
this pull request
Sep 28, 2025
* Move module_fft to source_base * Fix test build error * Rename namespace * Fix CUDA test error * Fix CUDA test bug * 2 * Finally fix CUDA test error * Finally fix fix test error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because module_fft may need to be used for other codes, so this module is moved from module_pw to source_base.