Skip to content

Conversation

@kirk0830
Copy link
Collaborator

@kirk0830 kirk0830 commented Oct 29, 2025

Linked Issue

Fix #6641

What's changed?

  • use the maximal cutoff radius of orbitals as the default search radius in neighboring atoms searching, because the parameter search_radius is always left unset (-1), this caused the too rough evaluation on neighboring list
  • include the origin atom itself in calculation of <a|L|b> matrix (this is a bug!)
  • add more annotations
  • polish the output to avoid potential misunderstanding and confusion

Any changes of core modules? (ignore if not applicable)

  • no

@kirk0830 kirk0830 marked this pull request as draft October 29, 2025 04:57
@kirk0830 kirk0830 marked this pull request as ready for review October 29, 2025 06:18
@kirk0830 kirk0830 changed the title Fix: adjust neighbor search loop condition in AngularMomentumCalculator Fix: set the maximal cutoff radius of orbital as the lower bound of search_radius in neighboring search tasks carried in out_mat_l Oct 29, 2025
@mohanchen mohanchen added Bugs Bugs that only solvable with sufficient knowledge of DFT Refactor Refactor ABACUS codes labels Oct 29, 2025
@mohanchen
Copy link
Collaborator

LGTM

@mohanchen mohanchen merged commit a201da3 into deepmodeling:develop Oct 29, 2025
14 checks passed
@kirk0830 kirk0830 deleted the fix-nadj-calcpLp branch October 29, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugs Bugs that only solvable with sufficient knowledge of DFT Refactor Refactor ABACUS codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The out_mat_l has no output in output file

2 participants