Remove DM from elecstate #6675
Merged
Remove DM from elecstate #6675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…update_pot, which is replaced by update_pot function in estate, the other is save2 function used in after_iter
mohanchen
added
Refactor
AsTonyshment
approved these changes
Nov 4, 2025
Collaborator
AsTonyshment
left a comment
AsTonyshment
left a comment
There was a problem hiding this comment.
LGTM! Separating DM from elecstate will enable us to avoid awkwardly invoking DM using methods like dynamic_cast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove DM from elecstate to avoid dynamic_cast operation to get density matrix.