Skip to content

Fix: fix a bug caused by intel compiler #6703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2025
Merged

Fix: fix a bug caused by intel compiler #6703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49264c5
fix a bug caused by intel compiler
dzzz2001 Nov 12, 2025
267be9b
change const reference to const value
dzzz2001 Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions source/source_base/ylm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,10 +324,10 @@ void Ylm::get_ylm_real( const int &Lmax, const ModuleBase::Vector3<double> &vec,
* *************************/
void Ylm::rlylm
(
const int& Lmax, //max momentum of l + 1
const double& x,
const double& y,
const double& z,
const int Lmax, //max momentum of l + 1
const double x,
const double y,
const double z,
double rly[]
)
{
Expand Down Expand Up @@ -529,10 +529,10 @@ void Ylm::rlylm
//return ylm, not rlylm
void Ylm::sph_harm
(
const int& Lmax, //max momentum of l
const double& xdr,
const double& ydr,
const double& zdr,
const int Lmax, //max momentum of l
const double xdr,
const double ydr,
const double zdr,
std::vector<double> &rly
)
{
Expand Down Expand Up @@ -668,10 +668,10 @@ void Ylm::sph_harm
// Peize Lin change rly 2016-08-26
void Ylm::rl_sph_harm
(
const int& Lmax, //max momentum of L
const double& x,
const double& y,
const double& z,
const int Lmax, //max momentum of L
const double x,
const double y,
const double z,
std::vector<double>& rly
)
{
Expand Down Expand Up @@ -807,10 +807,10 @@ void Ylm::rl_sph_harm

void Ylm::grad_rl_sph_harm
(
const int& Lmax, //max momentum of L
const double& x,
const double& y,
const double& z,
const int Lmax, //max momentum of L
const double x,
const double y,
const double z,
double* rly,
double** grly
)
Expand Down Expand Up @@ -1097,10 +1097,10 @@ void Ylm::grad_rl_sph_harm

void Ylm::hes_rl_sph_harm
(
const int& Lmax, //max momentum of L
const double& x,
const double& y,
const double& z,
const int Lmax, //max momentum of L
const double x,
const double y,
const double z,
std::vector<std::vector<double>>& hrly
)
{
Expand Down Expand Up @@ -1394,10 +1394,10 @@ void Ylm::test2 (void)

void Ylm::rlylm
(
const int& Lmax, //max momentum of l + 1
const double& x,
const double& y,
const double& z,
const int Lmax, //max momentum of l + 1
const double x,
const double y,
const double z,
double rly[],
double grly[][3]
)
Expand Down
48 changes: 24 additions & 24 deletions source/source_base/ylm.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@ class Ylm
* @param rly [in] calculated Ylm, Y00, Y10, Y11, Y1-1, Y20, Y21, Y2-1, Y22, Y2-2...
*/
static void rlylm(
const int& Lmax,
const double& x,
const double& y,
const double& z,
const int Lmax,
const double x,
const double y,
const double z,
double rly[]);

/**
Expand All @@ -70,10 +70,10 @@ class Ylm
* @param grly [out] gradient of Ylm, [dY00/dx, dY00/dy, dY00/dz], [dY10/dx, dY10/dy, dY10/dz], [dY11/dx, dY11/dy, dY11/dz],...
*/
static void rlylm(
const int& Lmax,
const double& x,
const double& y,
const double& z,
const int Lmax,
const double x,
const double y,
const double z,
double rly[],
double grly[][3]);

Expand All @@ -87,10 +87,10 @@ class Ylm
* @param rly [in] calculated Ylm, Y00, Y10, Y11, Y1-1, Y20, Y21, Y2-1, Y22, Y2-2...
*/
static void sph_harm(
const int& Lmax,
const double& xdr,
const double& ydr,
const double& zdr,
const int Lmax,
const double xdr,
const double ydr,
const double zdr,
std::vector<double> &rly);

/**
Expand All @@ -105,10 +105,10 @@ class Ylm
* @date 2016-08-26
*/
static void rl_sph_harm(
const int& Lmax,
const double& x,
const double& y,
const double& z,
const int Lmax,
const double x,
const double y,
const double z,
std::vector<double>& rly);

/**
Expand All @@ -123,10 +123,10 @@ class Ylm
* grly should be a memory-contiguous two-dimensional array for better performance.
*/
static void grad_rl_sph_harm(
const int& Lmax,
const double& x,
const double& y,
const double& z,
const int Lmax,
const double x,
const double y,
const double z,
double* rly,
double** grly);

Expand All @@ -140,10 +140,10 @@ class Ylm
* @param hrly [out] hessian of Ylm, [dY00/dx2, dY00/dxy, dY00/dxz, dY00/dyy, dY00/dyz, dY00/dzz] , ...
*/
static void hes_rl_sph_harm(
const int& Lmax,
const double& x,
const double& y,
const double& z,
const int Lmax,
const double x,
const double y,
const double z,
std::vector<std::vector<double>>& hrly);

//calculate the coefficient of Ylm, ylmcoef.
Expand Down
Loading