docs: remove deprecated model_devi_e_trust_lo/hi from dpgen run examples#1853
docs: remove deprecated model_devi_e_trust_lo/hi from dpgen run examples#1853wanghan-iapcm merged 2 commits intodevelfrom
Conversation
Co-authored-by: njzjz <9496702+njzjz@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated model_devi_e_trust_lo and model_devi_e_trust_hi parameters from dpgen run example configurations, as these parameters are no longer supported in the dpgen run command.
Key changes:
- Removed
model_devi_e_trust_loandmodel_devi_e_trust_hifrom three example configuration files underexamples/run/ - Parameters correctly preserved in
dpgen simplifymodule where they remain supported
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
examples/run/dp-calypso-vasp/param.json |
Removed deprecated energy trust parameters from CALYPSO-VASP example configuration |
examples/run/deprecated/dp2.x-lammps-vasp/CH4/param_CH4.yaml |
Removed deprecated energy trust parameters from CH4 YAML configuration |
examples/run/deprecated/dp2.x-lammps-vasp/Al/param_al_all_gpu.yaml |
Removed deprecated energy trust parameters from Al GPU YAML configuration |
Review Summary: The changes are clean and consistent. All three files correctly remove only the deprecated model_devi_e_trust_lo and model_devi_e_trust_hi parameters while preserving all other configuration settings. The JSON/YAML syntax remains valid after the removals. Verification confirms no remaining occurrences of these parameters exist in examples/run/ directory, and they are correctly preserved in the dpgen simplify module where they remain supported.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The
model_devi_e_trust_loandmodel_devi_e_trust_hiparameters have been deprecated indpgen runbut still exist in example configurations.Changes
Removed
model_devi_e_trust_loandmodel_devi_e_trust_hifrom 3 files inexamples/run/:dp-calypso-vasp/param.jsondeprecated/dp2.x-lammps-vasp/Al/param_al_all_gpu.yamldeprecated/dp2.x-lammps-vasp/CH4/param_CH4.yamlPreserved parameters in
dpgen simplifymodule and tests where still supportedExample
Original prompt
model_devi_e_trust_loandmodel_devi_e_trust_hifromdpgen runexamples #1852💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.