Skip to content

Conversation

@m1so
Copy link
Contributor

@m1so m1so commented Nov 11, 2025

Summary by CodeRabbit

  • Chores
    • Improved CI diagnostics by adding extra logging steps to surface dependency and environment details during checks.
    • Updated project dependencies: added matplotlib-inline (restricted to a compatible range) and removed a duplicate dependency entry to simplify package metadata.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 11, 2025

📝 Walkthrough

Walkthrough

Two diagnostic steps were added to the "mypy" job in the CI workflow (.github/workflows/ci.yml). The steps run after "Install project" and before "Run mypy": poetry show --tree and poetry self show plugins. No changes to error handling, control flow, or test logic. In pyproject.toml a duplicate toml dependency entry was removed and matplotlib-inline>=0.1.7,<0.2.0 was added to dependencies.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant GH as GitHub Actions
  participant Runner as CI Runner
  rect rgb(240,248,255)
    Note over GH,Runner: mypy job start
  end
  GH->>Runner: Checkout
  GH->>Runner: Install project
  rect rgb(224,255,224)
    Note over Runner: New diagnostic steps (added)
    Runner->>Runner: poetry show --tree
    Runner->>Runner: poetry self show plugins
  end
  Runner->>Runner: Run mypy
  alt success
    Runner->>GH: Upload results / exit 0
  else failure
    Runner->>GH: Upload logs / exit non‑zero
  end
Loading

Possibly related PRs

  • deepnote/deepnote-toolkit#158 — Introduced the CI workflow that this change modifies (same .github/workflows/ci.yml).

Suggested reviewers

  • mfranczel
  • hc2p

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title accurately reflects the primary change: adding Poetry dependency logging steps to CI workflow for debugging GitHub Actions caching issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2b193b6 and a30203f.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
  • GitHub Check: Build and push artifacts for Python 3.10
  • GitHub Check: Build and push artifacts for Python 3.9
  • GitHub Check: Build and push artifacts for Python 3.13
  • GitHub Check: Build and push artifacts for Python 3.12
  • GitHub Check: Build and push artifacts for Python 3.11
  • GitHub Check: Test - Python 3.13
  • GitHub Check: Test - Python 3.10
  • GitHub Check: Test - Python 3.12
  • GitHub Check: Test - Python 3.11
  • GitHub Check: Test - Python 3.9
  • GitHub Check: Typecheck - 3.9
  • GitHub Check: Typecheck - 3.13
  • GitHub Check: Typecheck - 3.11
  • GitHub Check: Typecheck - 3.12
🔇 Additional comments (1)
pyproject.toml (1)

127-127: Verify the matplotlib-inline version constraint rationale.

The constraint >=0.1.7,<0.2.0 is very narrow. Confirm whether:

  • The matplotlib 3.6.3 incompatibility with 0.2.0 is a real blocker
  • matplotlib-inline was already a transitive dependency (if so, why make it explicit now?)
  • This constraint applies across all supported Python versions (3.9–3.13)

If this is a temporary debugging change for the caching issue, consider documenting that.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

📦 Python package built successfully!

  • Version: 1.1.3.dev4+c7555cc
  • Wheel: deepnote_toolkit-1.1.3.dev4+c7555cc-py3-none-any.whl
  • Install:
    pip install "deepnote-toolkit @ https://deepnote-staging-runtime-artifactory.s3.amazonaws.com/deepnote-toolkit-packages/1.1.3.dev4%2Bc7555cc/deepnote_toolkit-1.1.3.dev4%2Bc7555cc-py3-none-any.whl"

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.07%. Comparing base (7d91cd6) to head (a30203f).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   76.94%   74.07%   -2.88%     
==========================================
  Files          99       98       -1     
  Lines        5514     5508       -6     
  Branches      754      754              
==========================================
- Hits         4243     4080     -163     
- Misses       1271     1428     +157     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

coderabbitai[bot]
coderabbitai bot previously approved these changes Nov 11, 2025
coderabbitai[bot]
coderabbitai bot previously approved these changes Nov 11, 2025
@deepnote-bot
Copy link

🚀 Review App Deployment Started

📝 Description 🌐 Link / Info
🌍 Review application ra-28
🔑 Sign-in URL Click to sign-in
📊 Application logs View logs
🔄 Actions Click to redeploy
🚀 ArgoCD deployment View deployment
Last deployed 2025-11-11 16:31:31 (UTC)
📜 Deployed commit a72bad371cbf3a241ca342c7e8a63c611b9fea8e
🛠️ Toolkit version c7555cc

@m1so m1so closed this Nov 11, 2025
@m1so m1so deleted the mb/debug-poetry-python-cache branch November 11, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants