Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -161,9 +161,12 @@
"args": "none"
}
],
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-explicit-any": "error",
"@typescript-eslint/no-namespace": "off",
"@typescript-eslint/no-use-before-define": "off",
"@typescript-eslint/no-floating-promises": "error",
"@typescript-eslint/no-non-null-assertion": "error",
"@typescript-eslint/prefer-nullish-coalescing": "error",
"@typescript-eslint/quotes": [
"error",
"single",
Expand Down
31 changes: 19 additions & 12 deletions src/components/NotebookPicker.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,23 @@ export class NotebookPicker extends ReactWidget {
constructor(private panel: NotebookPanel) {
super();

void panel.context.ready.then(() => {
const deepnoteMetadata = this.panel.context.model.getMetadata('deepnote');
const metadataNames = deepnoteMetadata?.notebook_names;
const names =
Array.isArray(metadataNames) &&
metadataNames.every(n => typeof n === 'string')
? metadataNames
: [];
panel.context.ready
.then(() => {
const deepnoteMetadata =
this.panel.context.model.getMetadata('deepnote');
const metadataNames = deepnoteMetadata?.notebook_names;
const names =
Array.isArray(metadataNames) &&
metadataNames.every(n => typeof n === 'string')
? metadataNames
: [];

this.selected = names.length === 0 ? null : (names[0] ?? null);
this.update();
});
this.selected = names.length === 0 ? null : (names[0] ?? null);
this.update();
})
.catch(error => {
console.error('Failed to initialize NotebookPicker:', error);
});
}

private handleChange = (event: React.ChangeEvent<HTMLSelectElement>) => {
Expand Down Expand Up @@ -68,7 +73,9 @@ export class NotebookPicker extends ReactWidget {
protected onAfterAttach(msg: Message): void {
super.onAfterAttach(msg);
requestAnimationFrame(() => {
MessageLoop.sendMessage(this.parent!, Widget.ResizeMessage.UnknownSize);
if (this.parent) {
MessageLoop.sendMessage(this.parent, Widget.ResizeMessage.UnknownSize);
}
});
}

Expand Down
4 changes: 3 additions & 1 deletion src/handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,11 @@ export async function requestAPI(
try {
response = await ServerConnection.makeRequest(requestUrl, init, settings);
} catch (error) {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
throw new ServerConnection.NetworkError(error as any);
}

// eslint-disable-next-line @typescript-eslint/no-explicit-any
let data: any = await response.text();

if (data.length > 0) {
Expand All @@ -39,7 +41,7 @@ export async function requestAPI(
}

if (!response.ok) {
throw new ServerConnection.ResponseError(response, data.message || data);
throw new ServerConnection.ResponseError(response, data.message ?? data);
}

return data;
Expand Down