-
Notifications
You must be signed in to change notification settings - Fork 0
docs: compatibility and maintenance plans #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: compatibility and maintenance plans #50
Conversation
GRN-4927 Document JupyterLab version compatibility and maintenance plans
Update README with this information. From https://jupyterlab.readthedocs.io/en/stable/extension/extension_dev.html#overview-of-extensions:
|
📝 WalkthroughWalkthroughThis pull request standardizes version constraints and documentation across the extension. It raises the minimum JupyterLab requirement to 4.4.0, adds explicit upper bounds (e.g., <5) to all JupyterLab-related dependencies in package.json and pyproject.toml, converts some package.json peerDependencies to dependencies, updates build hooks and pre-build install commands to require jupyterlab>=4.4.0,<5, updates CONTRIBUTING to prefer Sequence Diagram(s)sequenceDiagram
participant App as JupyterLab App
participant Plugin as Extension Plugin
participant Registry as ContentProviderRegistry
rect rgba(200,230,255,0.35)
App->>Plugin: activate(plugin)
Plugin->>Registry: check existence of content provider registry
end
alt Registry present (JupyterLab ≥ 4.4.0)
Registry-->>Plugin: registry object
Plugin->>App: register content provider / proceed
else Registry missing (JupyterLab < 4.4.0)
Plugin-->>App: throw Error("Content provider registry required — JupyterLab 4.4.0 or higher")
end
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (7)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
=======================================
Coverage 69.56% 69.56%
=======================================
Files 13 13
Lines 253 253
Branches 28 28
=======================================
Hits 176 176
Misses 73 73
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (5)
CONTRIBUTING.md(1 hunks)README.md(1 hunks)package.json(1 hunks)pyproject.toml(2 hunks)src/index.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: check_release
🔇 Additional comments (10)
pyproject.toml (2)
2-2: LGTM!Build-system constraint properly reflects the 4.4.0 minimum requirement.
81-81: Consistent with build-system requirements.The before-build-npm hook correctly uses the same version constraint as the build-system requires.
package.json (1)
74-75: Consistent with dependencies approach.DevDependencies follow the same explicit upper bound pattern as dependencies.
src/index.ts (2)
30-30: Helpful context for developers.The comment clearly explains why JupyterLab 4.4+ is required.
35-35: Clear and actionable error message.The error message specifies the exact minimum version requirement.
README.md (3)
11-11: Specific version requirement is clear.The requirement matches the version constraints in package.json and pyproject.toml.
13-20: Comprehensive compatibility explanation.The section clearly explains both the minimum requirement and the rationale for the upper bound.
21-42: Well-structured maintenance and compatibility documentation.The sections clearly explain semantic versioning policy, JupyterLab 5.x plans, and current pre-release status. The warning that 0.x.x APIs may change without notice is important context for users.
CONTRIBUTING.md (2)
149-156: Clear versioning guidance for contributors.The requirement and rationale are well-explained, with an accurate pyproject.toml example.
158-171: Helpful example with authoritative reference.The package.json example matches the actual file, and the link to JupyterLab's extension development best practices provides authoritative support for the upper bounds approach.
077b6f1 to
966e540
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (5)
CONTRIBUTING.md(1 hunks)README.md(2 hunks)package.json(1 hunks)pyproject.toml(2 hunks)src/index.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build
- GitHub Check: check_release
🔇 Additional comments (5)
pyproject.toml (1)
2-2: LGTM—version constraints align with 4.4.0 requirement.The build-system and pre-build hook now correctly enforce JupyterLab >=4.4.0,<5.
Also applies to: 81-81
src/index.ts (1)
30-30: LGTM—messaging clarifies 4.4.0 requirement.Comment and error message accurately reflect the content provider registry dependency.
Also applies to: 35-35
README.md (1)
11-11: LGTM—comprehensive compatibility documentation.Requirements and maintenance policy are clearly stated. Upper bound rationale is well-explained.
Also applies to: 53-83
CONTRIBUTING.md (2)
161-168: Example reflects package.json's incorrect constraints.The snippet shows
"@jupyterlab/application": "^4.0.0 <5", which permits versions before 4.4.0. Once package.json is corrected to^4.4.0 <5, update this example accordingly.
177-180: LGTM—copier command updated appropriately.The
--trustflag enables automated template application. Guidance to review and commit is clear.
Summary by CodeRabbit
Documentation
Chores