Merged
Conversation
voorhs
reviewed
Jan 28, 2025
Collaborator
voorhs
left a comment
voorhs
left a comment
There was a problem hiding this comment.
decision_metric->target_metric- из yaml файла еще же парсится список
metrics?
voorhs
approved these changes
Jan 31, 2025
Samoed
reviewed
Jan 31, 2025
| self.node_type = node_type | ||
| self.node_info = NODES_INFO[node_type] | ||
| self.metric_name = metric | ||
| self.decision_metric_name = target_metric |
Member
There was a problem hiding this comment.
А почему у нас тут остался все равно decision_metric_name?
Samoed
reviewed
Jan 31, 2025
| context: Context, | ||
| split: Literal["validation", "test"], | ||
| ) -> dict[str, float | str]: | ||
| def score(self, context: Context, split: Literal["validation", "test"], metrics: list[str]) -> dict[str, float]: |
Samoed
reviewed
Jan 31, 2025
| self.decision_metric_name = target_metric | ||
|
|
||
| self.metrics = metrics if metrics is not None else [] | ||
| if self.decision_metric_name not in self.metrics: |
Member
There was a problem hiding this comment.
А если он не в наших метриках то что происходит?
Member
|
@voorhs Давай ревертнем? Этот PR не готов |
Samoed
reviewed
Jan 31, 2025
Collaborator
А что не так? |
Member
|
Нет док стрингов и валидации названия |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.