Feat/async augmentations #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samoed
reviewed
Feb 2, 2025
Samoed
reviewed
Feb 2, 2025
Samoed
reviewed
Feb 6, 2025
Samoed
approved these changes
Feb 7, 2025
voorhs
reviewed
Feb 8, 2025
Comment on lines
+112
to
+118
| for sample in original_split: | ||
| utterance = sample[Dataset.utterance_feature] | ||
| label = sample[Dataset.label_feature] | ||
| intent_data = next(intent for intent in dataset.intents if intent.id == label) | ||
| for _ in range(n_evolutions): | ||
| tasks.append(self._evolve_async(utterance, intent_data)) | ||
| labels.append(intent_data.id) |
Collaborator
There was a problem hiding this comment.
тут проблема что если у нас стоит n_evolutions>1 то ведь надо применять несколько эволюций последовательно, типа результат предыдущей итераций подавать на вход следующей итерации
а не так что сделать несколько вариантов одной эволюции
а вообще мне кажется надо сделать параметр, который бы регулировал это поведение, потому что и то и другое поведение приемлемо
Collaborator
There was a problem hiding this comment.
если что можно отдельным PR решить эту проблему
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.