Merged
Conversation
voorhs
reviewed
Feb 12, 2025
Collaborator
voorhs
left a comment
voorhs
left a comment
There was a problem hiding this comment.
Я конечно не знаю работает ли, CI тут не запускаются
Я в пятницу у себя локально могу тесты прогнать
voorhs
approved these changes
Feb 14, 2025
voorhs
added a commit
that referenced
this pull request
Feb 14, 2025
* define interface * basic ho iterator * move obtaining data for train from node optimizer to modules themselves * stage progress * implement cv iterator * minor bug fix * implement cv iterator for decision node * move cv iteration to base module definition * implement cv iterator for embedding node * add training to `score_ho` of each node * properly define base module * fix codestyle * remove regexp node * remove regexp validator * fix typing problems (except `DataHandler._split_cv`) * add ingore oos decorator * fix codestyle * fix typing * add oos handling to cv iterator * remove `DataHandler.dump()` * minor bug fix * implement splitting to cv folds * fix codestyle * remove regex tests * bug fix * bug fix * update tests * fix typing * big fix * basic test on cv folding * add tests for metrics to ignore oos samples * add tests for cv iterator * fix codestyle * minor bug fix * fix codestyle * add test for cv * bug fix * implement cv iterator for description scorer * refactor cv iterator for description node * fix typing * add cache cleaning before refitting * bug fix * implement refitting the whole pipeline with all train data * fix typing * bug fix * fix typing * respond to samoed * create `ValidationType` in `autointent.custom_types` * fix docstring * properly expose `n_folds` argument * implement `_fit_bayes` * add typing to param spaces * minor bug fix * minor bug fix * fix codestyle * add tuning selection to pipeline * add test on bayes * disable search space validation for now * fix codestyle * remove `ParamSpaceCat` (it's redundant) * move to optuna entirely * refactor yaml format a little bit * add test for random sampler * rename some variables * add config validation for optuna (#132) * add config validation * add validation for union types * remove debug code * remove comment * run tests on pr for all branches * fix mlknn * fix type validation * return CI config back to normal * fix default value for step in `ParamSpaceFloat` * update schema * update callback test * change CI config * update search space configs for testing * enable validation back * remove TunableDecision from search spaces * upd schema --------- Co-authored-by: Roman Solomatin <samoed.roman@gmail.com> Co-authored-by: Roman Solomatin <36135455+Samoed@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Также для дополнительной валидации типов добавил в некоторых местах
PositiveInt,FloatFromZeroToOne