Feat/basic presets #146
Merged
Feat/basic presets #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@Samoed с последним коммитом локально у меня тесты прошли, можно работать над включением **clf_args: Any |
Samoed
reviewed
Feb 25, 2025
autointent/_dataset/_dataset.py
Outdated
| sample["label"] = ohe_vector | ||
| return sample | ||
|
|
||
| def validate_descriptions(self) -> None: |
Member
There was a problem hiding this comment.
Добавь докстринг, тк не понятно зачем это
autointent/_pipeline/_pipeline.py
Outdated
Comment on lines
118
to
122
| if isinstance(config, Path | str): | ||
| with Path(config).open() as file: | ||
| dict_params = yaml.safe_load(file) | ||
| elif isinstance(config, dict): | ||
| dict_params = config |
Member
There was a problem hiding this comment.
Suggested change
| if isinstance(config, Path | str): | |
| with Path(config).open() as file: | |
| dict_params = yaml.safe_load(file) | |
| elif isinstance(config, dict): | |
| dict_params = config | |
| elif isinstance(config, Path | str): | |
| with Path(config).open() as file: | |
| dict_params = yaml.safe_load(file) | |
| elif isinstance(config, dict): | |
| dict_params = config | |
| else: | |
| raise Error |
Collaborator
Author
There was a problem hiding this comment.
я assert_never поставлю, ок же?
| clf_args: dict[str, Any] | None = None, | ||
| clf_name: str, | ||
| embedder_config: EmbedderConfig | str | None = None, | ||
| **clf_args: Any, # noqa: ANN401 |
Member
There was a problem hiding this comment.
Вроде для генерации конфигов надо
Suggested change
| **clf_args: Any, # noqa: ANN401 | |
| **clf_args: int | float | Any, |
Samoed
reviewed
Feb 26, 2025
| "default": [ | ||
| null | ||
| ], | ||
| "clf_args": { |
Member
There was a problem hiding this comment.
Кажется, что с этим конфигом перебор параметров работать не будет для sklearn
Collaborator
Author
There was a problem hiding this comment.
Я пока валидацию отключил, все работает
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.