feat: change log time for wandb #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samoed
reviewed
Mar 19, 2025
| None, description="List of callbacks to report to. If None, no callbacks will be used" | ||
| ) | ||
| log_interval_time: float = Field( | ||
| 0.1, description="Sampling interval for the system monitor in seconds for Wandb logger." |
Collaborator
Author
There was a problem hiding this comment.
in seconds. ну я поставила 0.1 от секунды получаеся
voorhs
reviewed
Mar 20, 2025
Comment on lines
34
to
45
| def start_run(self, run_name: str, dirpath: Path, log_interval_time: float) -> None: | ||
| """Starts a new run and sets the directory for storing logs. | ||
| Args: | ||
| run_name: Name of the run. | ||
| dirpath: Path to the directory where logs will be saved. | ||
| log_interval_time: Sampling interval for the system monitor in seconds. | ||
| (not utilized in Tensorboard logging). | ||
| """ | ||
| self.run_name = run_name | ||
| self.dirpath = dirpath | ||
| self.log_interval_time = log_interval_time |
Collaborator
There was a problem hiding this comment.
если в тензорборде не испольуется то тогда мб сделать float | None = None
Member
There was a problem hiding this comment.
Или просто чтобы логирование могло прнимать доп параметры, а потом каждый логер сам отдельно их обрабатывать
voorhs
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.