Conversation
voorhs
reviewed
Jan 17, 2025
voorhs
reviewed
Jan 17, 2025
voorhs
reviewed
Jan 18, 2025
Collaborator
voorhs
left a comment
voorhs
left a comment
There was a problem hiding this comment.
все штуки связанные с переходом на Dataset я сделаю в отдельной ветке
* refactor basic utterance generator * make `load_dataset` utility public * polish `load_dataset` utility * move basic utterance generator to `Dataset` * refactor cli for basic utterance generator * refactor evolutions module * some bug fix in basic utterance generation * some bug fix in evolutionary augmentations * refactor `Generator` and fix codestyle * fix typing
voorhs
approved these changes
Jan 27, 2025
Collaborator
voorhs
left a comment
voorhs
left a comment
There was a problem hiding this comment.
TODO
- тесты для UtteranceEvolver и UtteranceGenerator
- промты кастомизируемые пользователем (кажется надо написать отдельный класс)
- асинхронный режим для Generator
- в целом лучше продумать структуру этого раздела нашей библиотеки (должны логично соседствовать методы основанные на ллм и на регулярках)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.