Skip to content

Conversation

@rock-n-shrimproll
Copy link
Collaborator

Description

Please describe here what changes are made and why.

Checklist

  • I have performed a self-review of the changes

List here tasks to complete in order to mark this PR as ready for review.

To Consider

  • Add tests (if functionality is changed)
  • Update API reference / tutorials / guides
  • Update CONTRIBUTING.md (if devel workflow is changed)
  • Update .ignore files, scripts (such as lint), distribution manifest (if files are added/deleted)
  • Search for references to changed entities in the codebase

Comment on lines +206 to +207
:py:data:`~.AnyCondition` is invoked before each component execution;
component is executed only if it returns ``True``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the doc (this is copied from component docs, there are no components for processing functions).

@@ -1,2 +1,2 @@
from .standard import ModifyResponse
from .standard import ModifyResponse, FallbackResponse
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use this diff to see if there are any FallbackResponse changes remaining.
But, really, the best option is to revert the commits.

@RLKRo RLKRo closed this Feb 7, 2025
@RLKRo RLKRo mentioned this pull request Feb 7, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants