Fix duplicate macro definition and incorrect error message#163
Open
hobostay wants to merge 1 commit intodeepseek-ai:mainfrom
Open
Fix duplicate macro definition and incorrect error message#163hobostay wants to merge 1 commit intodeepseek-ai:mainfrom
hobostay wants to merge 1 commit intodeepseek-ai:mainfrom
Conversation
- Remove duplicate TRAP_ONLY_DEVICE_ASSERT macro definition in csrc/utils.h The macro was defined twice with identical content (lines 41-47 and 49-55) - Fix incorrect error message in csrc/api/dense_decode.h (line 61) The error message said "Only head_size_v == 576 is supported" but the condition checks for head_size_v == 512, causing misleading error output Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two code quality issues in the FlashMLA codebase:
Remove duplicate
TRAP_ONLY_DEVICE_ASSERTmacro definition incsrc/utils.h#ifndefguard, this is redundant code that should be cleaned upFix incorrect error message in
csrc/api/dense_decode.h(line 61)head_size_v == 512Changes
csrc/utils.h: Removed the duplicateTRAP_ONLY_DEVICE_ASSERTmacro definitioncsrc/api/dense_decode.h: Fixed error message to correctly reflect the validated valueTest plan
🤖 Generated with Claude Code