Skip to content

refactor: update sessions map#46

Open
harsh-98 wants to merge 3 commits intodeepseeksss:masterfrom
harsh-98:master
Open

refactor: update sessions map#46
harsh-98 wants to merge 3 commits intodeepseeksss:masterfrom
harsh-98:master

Conversation

@harsh-98
Copy link

No description provided.

@zonyitoo
Copy link
Collaborator

This would be a breaking change. Keeping conv to be an async function should have no extra cost.

@harsh-98
Copy link
Author

This would be a breaking change. Keeping conv to be an async function should have no extra cost.

Mark conv as async.

@harsh-98 harsh-98 changed the title fix: conv is not async and update sessions map refactor: update sessions map May 14, 2025
@zonyitoo
Copy link
Collaborator

You should run cargo fmt and cargo clippy to use Rust common coding style.

@zonyitoo
Copy link
Collaborator

What's the difference between your changed version and the older one?

@harsh-98
Copy link
Author

This is just refactor now, removing common logic for adding new session.

@zonyitoo
Copy link
Collaborator

There are too many .unwrap() in your refactored code, which is not Rust-styled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants