Skip to content

Conversation

@ChinmayBansal
Copy link
Contributor

Related Issues

Proposed Changes:

Added delete_all_documents() and delete_all_documents_async() methods to PineconeDocumentStore to enable deletion of all documents from an index namespace.

Implementation details:

Files changed:

How did you test it?

  • Unit tests: hatch run test:unit - 17 passed
  • Integration tests: Added 4 new integration tests (2 sync + 2 async):
    • test_delete_all_documents: Verifies deletion of multiple documents
    • test_delete_all_documents_empty_collection: Verifies behavior with empty collection
    • test_delete_all_documents_async: Async version with multiple documents
    • test_delete_all_documents_async_empty_collection: Async version with empty collection

Notes for the reviewer

  • Implementation follows the pattern established in OpenSearch PR feat: adding the operation delete_all_documents to the OpenSearchDocumentStore #2321 (reference implementation for parent issue #8508)
  • Uses Pinecone's native delete_all=True parameter which efficiently deletes all vectors in the specified namespace
  • Consistent with existing delete_documents() method in the same file
  • No recreate_index parameter needed - Pinecone handles index management differently than search engines

Checklist

@ChinmayBansal ChinmayBansal requested a review from a team as a code owner October 18, 2025 19:08
@ChinmayBansal ChinmayBansal requested review from mpangrazzi and removed request for a team October 18, 2025 19:08
@github-actions github-actions bot added integration:pinecone type:documentation Improvements or additions to documentation labels Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:pinecone type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add delete_all_documents() operation to PineconeDocumentStore

1 participant