feat: OpenRouterChatGenerator add integration tests for mixing Tool/Toolset
#2421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:openrouter
type:documentation
vblagoje
changed the title
OpenRouterChatGenerator add integration tests for mixing Tool/Toolset
vblagoje
requested review from
Amnah199 and
julian-risch
and removed request for
a team and
julian-risch
Amnah199
reviewed
Oct 21, 2025
Comment on lines
701
to
702
| component = OpenRouterChatGenerator(tools=toolset) | ||
|
|
There was a problem hiding this comment.
@vblagoje In the issue it says we are allowed to pass tool and toolsets in the same list.
Amnah199
reviewed
Oct 21, 2025
Comment on lines
642
to
644
| # Pass both tools at runtime - runtime tools should take precedence | ||
| messages = [ChatMessage.from_user("What's the time in Tokyo?")] | ||
| results = component.run(messages, tools=[time_tool]) |
There was a problem hiding this comment.
The comment says pass both tools, although only one tool is passed to run method.
Amnah199
reviewed
Oct 23, 2025
|
|
||
| # Pass echo_tool as a list at runtime - runtime tools should take precedence | ||
| messages = [ChatMessage.from_user("Echo this: Hello World")] | ||
| results = component.run(messages, tools=[echo_tool]) |
There was a problem hiding this comment.
@vblagoje we need to update this to test passing mixed list of tools and toolsets instead of overriding init tools.
Amnah199
reviewed
Oct 23, 2025
|
|
||
| # Pass echo_tool as a list at runtime - runtime tools should take precedence | ||
| messages = [ChatMessage.from_user("Echo this: Hello World")] | ||
| results = await component.run_async(messages, tools=[echo_tool]) |
There was a problem hiding this comment.
@vblagoje please update this as well like the above test
Amnah199
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Add integration tests for
ToolsTypeHaystack 2.19 updatespart of:
What:
How did you test it: