refactor(valkey): use async DocumentStore mixin tests#3060
Open
SyedShahmeerAli12 wants to merge 11 commits intodeepset-ai:mainfrom
Open
refactor(valkey): use async DocumentStore mixin tests#3060SyedShahmeerAli12 wants to merge 11 commits intodeepset-ai:mainfrom
SyedShahmeerAli12 wants to merge 11 commits intodeepset-ai:mainfrom
Conversation
Adds a new Haystack integration for Tavily, an AI-powered web search API optimized for LLM applications. Implements sync and async search via TavilyClient and AsyncTavilyClient, following the WebSearch component interface used by existing integrations. Closes deepset-ai#2961 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Inherit from async mixin classes introduced in deepset-ai/haystack#10975 to eliminate duplicate test code in TestValkeyDocumentStoreAsync. Mixins added (from haystack.testing.document_store and document_store_async): - CountDocumentsAsyncTest - WriteDocumentsAsyncTest - DeleteDocumentsAsyncTest - DeleteAllAsyncTest - DeleteByFilterAsyncTest - UpdateByFilterAsyncTest - CountDocumentsByFilterAsyncTest - CountUniqueMetadataByFilterAsyncTest - GetMetadataFieldMinMaxAsyncTest - GetMetadataFieldUniqueValuesAsyncTest Override WriteDocumentsAsyncTest methods that rely on DuplicatePolicy.FAIL and DuplicatePolicy.SKIP, which are not supported by ValkeyDocumentStore. Closes deepset-ai#3053 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
SyedShahmeerAli12
requested review from
julian-risch
and removed request for
a team
github-actions
bot
added
topic:CI
integration:valkey
integration:tavily
type:documentation
- Override test_update_by_filter_async: uses filterable_docs fixture with undeclared 'chapter' field. Use declared fields (category, priority) instead. - Override test_count_unique_metadata_by_filter_async_with_multiple_filters: uses undeclared 'year' field. Use declared fields (category, priority) instead. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Break long Document() lines to stay within 120-char limit - Remove @staticmethod from test_count_unique_metadata_by_filter_async_with_multiple_filters so pytest can inject the document_store fixture correctly Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3053
Refactors
integrations/valkey/tests/test_document_store_async.pyto inherit from the asyncmixin classes introduced in deepset-ai/haystack#10975.
WriteDocumentsAsyncTestmethods for unsupported duplicate policies (FAIL,SKIP) since ValkeyDocumentStore only supportsNONEandOVERWRITE