Skip to content

fix: configure logging on 'haystack' logger instead of root logger #10763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaxwellCalkin wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: configure logging on 'haystack' logger instead of root logger #10763

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73cc80f
fix: configure logging handler on 'haystack' logger instead of root
MaxwellCalkin Mar 8, 2026
c2c24c1
Merge branch 'main' into fix/no-root-logger-handlers
davidsbatista Mar 11, 2026
a108520
Merge branch 'main' into fix/no-root-logger-handlers
davidsbatista Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions haystack/logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,12 +392,12 @@ def configure_logging(use_json: bool | None = None) -> None:
# Use OUR `ProcessorFormatter` to format all `logging` entries.
handler.setFormatter(formatter)

root_logger = logging.getLogger()
haystack_logger = logging.getLogger("haystack")
# avoid adding our handler twice
old_handlers = [
h
for h in root_logger.handlers
for h in haystack_logger.handlers
if not (isinstance(h, logging.StreamHandler) and h.name == "HaystackLoggingHandler")
]
new_handlers = [handler, *old_handlers]
root_logger.handlers = new_handlers
haystack_logger.handlers = new_handlers
Loading