Skip to content

fix: replace bare except with except Exception#10893

Open
YouFoxGirl wants to merge 1 commit intodeepset-ai:mainfrom
YouFoxGirl:foxclaw/fix-2026-03-21T23-18-37
Open

fix: replace bare except with except Exception#10893
YouFoxGirl wants to merge 1 commit intodeepset-ai:mainfrom
YouFoxGirl:foxclaw/fix-2026-03-21T23-18-37

Conversation

@YouFoxGirl
Copy link

@YouFoxGirl YouFoxGirl commented Mar 22, 2026

What this PR does

Replace bare except: clauses with except Exception: to avoid catching
KeyboardInterrupt and SystemExit. Added a TODO note for future
more specific exception handling where applicable.

Why this matters

Bare except: catches all exceptions including KeyboardInterrupt
and SystemExit, which can hide bugs and make debugging harder.

@YouFoxGirl YouFoxGirl requested a review from a team as a code owner March 22, 2026 02:17
@YouFoxGirl YouFoxGirl requested review from anakin87 and removed request for a team March 22, 2026 02:17
@vercel
Copy link

vercel bot commented Mar 22, 2026

Someone is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


FoxClaw Bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Use except Exception: instead of bare except: to avoid catching
KeyboardInterrupt and SystemExit.
@YouFoxGirl YouFoxGirl force-pushed the foxclaw/fix-2026-03-21T23-18-37 branch from d0217e7 to df1427a Compare March 22, 2026 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants