Skip to content

Conversation

@Hansehart
Copy link
Contributor

Related Issues

N/A

Proposed Changes

This PR corrects the type hint of the meta parameter in the AzureOCRDocumentConverter.run() method.

Previously:

meta: Optional[list[dict[str, Any]]] = None

Now:

meta: Optional[Union[dict[str, Any], list[dict[str, Any]]]] = None

This makes the type annotation accurate to actual runtime behavior, since normalize_metadata() accepts both a single dict and a list of dicts.

How did you test it?

Ran existing unit tests for AzureOCRDocumentConverter.

Notes for the reviewer

The change only affects the type annotation and does not modify any runtime logic. This improves IDE and static type-checking support.

@Hansehart Hansehart requested a review from a team as a code owner October 23, 2025 19:33
@Hansehart Hansehart requested review from Amnah199 and removed request for a team October 23, 2025 19:33
@vercel
Copy link

vercel bot commented Oct 23, 2025

@Hansehart is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Oct 23, 2025

CLA assistant check
All committers have signed the CLA.

@sjrl sjrl requested review from sjrl and removed request for Amnah199 October 24, 2025 08:10
@sjrl sjrl self-assigned this Oct 24, 2025
@sjrl sjrl added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Oct 24, 2025
@sjrl
Copy link
Contributor

sjrl commented Oct 24, 2025

@Hansehart thanks for the fix! Could you run hatch run fmt haystack locally to fix the formatting issue?

@github-actions github-actions bot added the type:documentation Improvements on the docs label Oct 24, 2025
Copy link
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sjrl sjrl enabled auto-merge (squash) October 27, 2025 08:34
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 18801669717

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 23 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 92.199%

Files with Coverage Reduction New Missed Lines %
core/pipeline/async_pipeline.py 3 65.88%
components/converters/azure.py 20 89.2%
Totals Coverage Status
Change from base Build 18783509336: -0.02%
Covered Lines: 13461
Relevant Lines: 14600

💛 - Coveralls

@sjrl sjrl merged commit c2f964b into deepset-ai:main Oct 27, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes. type:documentation Improvements on the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants