Merged
Conversation
Signed-off-by: Stas Bekman <stas@stason.org>
…rate Signed-off-by: Stas Bekman <stas@stason.org>
6 tasks
tohtana
approved these changes
Oct 22, 2025
Collaborator
Author
|
Thank you for reviewing, Masahiro |
NirSonnenschein
pushed a commit
to NirSonnenschein/DeepSpeed
that referenced
this pull request
Oct 26, 2025
Ulysses/ALST integration with HF Accelerate: - Allow `UlyssesSPAttentionHF.register_with_transformers` to get a `model` obj as an argument, to match HF accelerate's workflow - Fix existing Ulysses' tests to tests z2 instead of z1 - Improve documentation - Add a defensive check The HF Accelerate PR that depends on this PR is here huggingface/accelerate#3817 --------- Signed-off-by: Stas Bekman <stas@stason.org> Signed-off-by: Nir Sonnenschein <nsonnenschein@habana.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ulysses/ALST integration with HF Accelerate:
UlyssesSPAttentionHF.register_with_transformersto get amodelobj as an argument, to match HF accelerate's workflowThe HF Accelerate PR that depends on this PR is here huggingface/accelerate#3817