Skip to content

ds-sequence-parallel(ulysses) for rope. #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
inkcherry wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ds-sequence-parallel(ulysses) for rope. #392

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fae532
ds-sp(ulysses) for rope
inkcherry May 30, 2024
eedfe9c
remove print
inkcherry May 30, 2024
d1ca6bb
fix format
inkcherry Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions megatron/model/language_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,10 @@ def forward(self, enc_input_ids, enc_position_ids, enc_attn_mask,
else:
if args.curriculum_learning_legacy or args.data_efficiency_curriculum_learning:
rotary_pos_emb = self.rotary_pos_emb(args.curriculum_seqlen)
elif args.ds_sequence_parallel_size > 1:
parallel_seq_len = self.seq_length / args.ds_sequence_parallel_size
ds_sp_offset = mpu.get_sequence_parallel_rank() * parallel_seq_len
rotary_pos_emb = self.rotary_pos_emb(parallel_seq_len, ds_sp_offset)
else:
rotary_pos_emb = self.rotary_pos_emb(self.seq_length)

Expand Down