Open
Conversation
|
⬆️ Go test coverage increased from 86.4% to 87.3% compared to c25763d
Updated Package Coverages: # Package Name | Prior | New
+ github.com/deevus/truenas-go | 83.2% | 85.2%
+ github.com/deevus/truenas-go/client | 88.9% | 89.1%View coverage for all packages# Package Name | Coverage
+ github.com/deevus/truenas-go | 85.2%
+ github.com/deevus/truenas-go/api | 87.5%
+ github.com/deevus/truenas-go/client | 89.1%
+ github.com/deevus/truenas-go/cmd/featurematrix | 92.9% |
deevus
force-pushed
the
feat/user-group-services
branch
2 times, most recently
from
768801a to
30ce808
Compare
Add CRUD services for TrueNAS user and group management via the user.* and group.* API namespaces. Both services use the Caller interface (synchronous operations only). GroupService: Create, Get, GetByName, GetByGID, List, Update, Delete UserService: Create, Get, GetByUsername, GetByUID, List, Update, Delete Includes full test coverage for conversion logic, CRUD operations, not-found handling, and mock/interface compliance. Closes #7 Co-Authored-By: Mircea-Pavel Anton <contact@mirceanton.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
deevus
force-pushed
the
feat/user-group-services
branch
from
30ce808 to
92d81ec
Compare
- Parse user.create response as {"id": N} object instead of bare int
- Always send email field in create/update params (allows clearing)
- Make group_create and home_create conditional (only sent when true)
- Update tests to match corrected API call patterns
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Change sampleUserJSON() to return json.RawMessage (matches all other test helpers) - Add Delete_Error tests for both UserService and GroupService - Add comment explaining "group" filter field in GetByName - Regenerate feature matrix Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GroupServicewith CRUD operations (Create, Get, GetByName, GetByGID, List, Update, Delete) via thegroup.*API namespaceUserServicewith CRUD operations (Create, Get, GetByUsername, GetByUID, List, Update, Delete) via theuser.*API namespaceCallerinterface (synchronous operations only)Closes #7
Migrates API layer from terraform-provider-truenas#7 by @mircea-pavel-anton.
Test plan
groupFromResponse,userFromResponse, opts-to-params)(nil, nil)viaisNotFoundError-raceflaggo vetclean🤖 Generated with Claude Code