fix: support three-part TrueNAS version strings (25.10+)#9
Merged
Conversation
TrueNAS 25.10+ uses three-part versions like "TrueNAS-25.10.1" instead of four-part "TrueNAS-SCALE-24.10.2.4". Make the build segment optional in the version regex, defaulting to 0 when absent. Closes #4 Co-Authored-By: dalton perdue <dalton@perdue.io> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
⬆️ Go test coverage increased from 86.2% to 86.3% compared to efb7db6
Updated Package Coverages: # Package Name | Prior | New
+ github.com/deevus/truenas-go/client | 88.6% | 88.8%View coverage for all packages# Package Name | Coverage
+ github.com/deevus/truenas-go | 83.1%
+ github.com/deevus/truenas-go/api | 87.5%
+ github.com/deevus/truenas-go/client | 88.8%
+ github.com/deevus/truenas-go/cmd/featurematrix | 92.9% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TrueNAS-25.10.1) instead of four-part (TrueNAS-SCALE-24.10.2.4). Makes the build segment optional, defaulting to 0.Closes #4
Test plan
TrueNAS-25.10.1) passesgo vet ./...clean🤖 Generated with Claude Code