Retry cleanups #318
Open
Retry cleanups #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 28, 2017 12:59
Default to milliseconds internally. The behavior would be incorrect with any other time unit anyway: due to multiple unit.toMillis(unit.toMillis(unit.toMillis(x))) conversions. Extract duplicating code in unit test.
NakadiException.throwNonNull throws IllegalStateException while NakadiException is itself exception, also throwNonNull is a non null check that is retrofitted to throw unconditionally. This all is rather confusing.
PetrGlad
commented
Nov 28, 2017
| return nextBackOffMillis(System.currentTimeMillis()); | ||
| } | ||
|
|
||
| long nextBackOffMillis(long nowMillis) { |
Contributor
Author
There was a problem hiding this comment.
Extracted for testing.
| } | ||
|
|
||
| workingInterval = unit.toMillis(workingInterval) * (workingAttempts * workingAttempts); | ||
| workingInterval = workingInterval * (workingAttempts * workingAttempts); |
Contributor
Author
There was a problem hiding this comment.
This still looks like too aggressive increase. workingInterval = startingInterval * pow(workingInterval, 2) would be OK (and easier to review).
| exponentialRetry.nextBackOffMillis(100); | ||
| assertFalse(exponentialRetry.isFinished()); | ||
| exponentialRetry.nextBackOffMillis(101); | ||
| assertFalse(exponentialRetry.isFinished()); |
Contributor
Author
There was a problem hiding this comment.
Would previously fail here as accumulated time was 202 milliseconds (instead of 101).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context see #315