Support custom certificate lifetime#932
Open
janh wants to merge 1 commit intodehydrated-io:masterfrom
Open
Conversation
The ACME protocol allows to request a specific lifetime using the fields "notBefore" and "notAfter" when creating an order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ACME protocol allows to request a specific lifetime using the fields "notBefore" and "notAfter" when creating an order (see also #806).
This change allows to specify the desired lifetime using the new
LIFETIME_SECSoption.The "notBefore" time is back-dated by 1 hour (Let's Encrypt and Google Trust Services also do this by default). Not sure if this should also be configurable.